This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Update resolvers.md #744
Open
Update resolvers.md #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I propose removing unnecessary async keyword for regular function. I also found confusing the code block for src/schema.js following the explanation of the resolver for Mission type. The schema shown in the code block differs from what was shown to the user in previous sections and the changes introduced are not relevant as the mission argument that precedes size is never used on this section.
|
@rafmjr: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose removing unnecessary async keyword for regular function.
I also found confusing the code block for src/schema.js following the explanation of the resolver for Mission type. The schema shown in the code block differs from what was shown to the user in previous sections and the changes introduced are not relevant as the mission argument that precedes size is never used on this section.