Add missing deprecated input value printing for subgraph printer.

Add tests for printing @SpecifiedBy and deprecated input values.
apollographql · Sep 1, 2021 · c524cda · c524cda
1 parent 084a76f
commit c524cda
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/federation-integration-testsuite-js/src/fixtures/accounts.ts b/federation-integration-testsuite-js/src/fixtures/accounts.ts
@@ -23,6 +23,8 @@ export const typeDefs = gql`
     inheritMaxAge: Boolean
   ) on FIELD_DEFINITION | OBJECT | INTERFACE | UNION
 
+  scalar JSON @specifiedBy(url: "https://json-spec.dev")
+
   schema {
     query: RootQuery
     mutation: Mutation
@@ -65,7 +67,11 @@ export const typeDefs = gql`
   }
 
   type Mutation {
-    login(username: String!, password: String!): User
+    login(
+      username: String!
+      password: String!
+      userId: String @deprecated(reason: "Use username instead")
+    ): User
   }
 
   extend type Library @key(fields: "id") {

diff --git a/federation-js/src/service/__tests__/printFederatedSchema.test.ts b/federation-js/src/service/__tests__/printFederatedSchema.test.ts
@@ -86,6 +86,8 @@ describe('printFederatedSchema', () => {
         url: String!
       }
 
+      scalar JSON @specifiedBy(url: \\"https://json-spec.dev\\")
+
       type KeyValue {
         key: String!
         value: String!
@@ -101,7 +103,7 @@ describe('printFederatedSchema', () => {
 
       type Mutation {
         deleteReview(id: ID!): Boolean
-        login(password: String!, username: String!): User
+        login(password: String!, userId: String @deprecated(reason: \\"Use username instead\\"), username: String!): User
         reviewProduct(body: String!, upc: String!): Product
         updateReview(review: UpdateReviewInput!): Review
       }

diff --git a/federation-js/src/service/__tests__/printSupergraphSdl.test.ts b/federation-js/src/service/__tests__/printSupergraphSdl.test.ts
@@ -164,6 +164,8 @@ describe('printSupergraphSdl', () => {
         REVIEWS @join__graph(name: \\"reviews\\" url: \\"https://reviews.api.com\\")
       }
 
+      scalar JSON @specifiedBy(url: \\"https://json-spec.dev\\")
+
       type KeyValue {
         key: String!
         value: String!
@@ -183,7 +185,7 @@ describe('printSupergraphSdl', () => {
 
       type Mutation {
         deleteReview(id: ID!): Boolean @join__field(graph: REVIEWS)
-        login(password: String!, username: String!): User @join__field(graph: ACCOUNTS)
+        login(password: String!, userId: String @deprecated(reason: \\"Use username instead\\"), username: String!): User @join__field(graph: ACCOUNTS)
         reviewProduct(body: String!, upc: String!): Product @join__field(graph: REVIEWS)
         updateReview(review: UpdateReviewInput!): Review @join__field(graph: REVIEWS)
       }

diff --git a/federation-js/src/service/printFederatedSchema.ts b/federation-js/src/service/printFederatedSchema.ts
@@ -359,7 +359,7 @@ function printInputValue(arg: GraphQLInputField) {
   if (defaultAST) {
     argDecl += ` = ${print(defaultAST)}`;
   }
-  return argDecl;
+  return argDecl + printDeprecated(arg.deprecationReason);
 }
 
 function printDirective(directive: GraphQLDirective) {

diff --git a/gateway-js/src/__tests__/loadSupergraphSdlFromStorage.test.ts b/gateway-js/src/__tests__/loadSupergraphSdlFromStorage.test.ts
@@ -171,6 +171,8 @@ describe('loadSupergraphSdlFromStorage', () => {
         REVIEWS @join__graph(name: \\"reviews\\" url: \\"https://reviews.api.com\\")
       }
 
+      scalar JSON @specifiedBy(url: \\"https://json-spec.dev\\")
+
       type KeyValue {
         key: String!
         value: String!
@@ -190,7 +192,7 @@ describe('loadSupergraphSdlFromStorage', () => {
 
       type Mutation {
         deleteReview(id: ID!): Boolean @join__field(graph: REVIEWS)
-        login(password: String!, username: String!): User @join__field(graph: ACCOUNTS)
+        login(password: String!, userId: String @deprecated(reason: \\"Use username instead\\"), username: String!): User @join__field(graph: ACCOUNTS)
         reviewProduct(body: String!, upc: String!): Product @join__field(graph: REVIEWS)
         updateReview(review: UpdateReviewInput!): Review @join__field(graph: REVIEWS)
       }