Skip to content

Commit

Permalink
Fix publishing process to include dist directory (#2583)
Browse files Browse the repository at this point in the history
PR #2559 removed a postinstall build step which our publish
action depended on. This replaces the missing build step.
  • Loading branch information
trevor-scheer committed May 17, 2023
1 parent fed24b4 commit c96e24c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
12 changes: 12 additions & 0 deletions .changeset/curly-windows-rule.md
@@ -0,0 +1,12 @@
---
"@apollo/composition": patch
"apollo-federation-integration-testsuite": patch
"@apollo/gateway": patch
"@apollo/federation-internals": patch
"@apollo/query-graphs": patch
"@apollo/query-planner": patch
"@apollo/subgraph": patch
---

Supersedes v2.4.4 due to a publishing error with no dist/ folder

2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Expand Up @@ -34,7 +34,7 @@ jobs:
with:
title: "release: on branch ${{ github.ref_name }}"
createGithubReleases: true
publish: npm run publish
publish: npm run build-and-publish
# workaround for https://github.com/changesets/action/issues/203, includes an `npm i` after running the version command
version: npm run changeset-version
env:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -24,7 +24,7 @@
"hints-doc:check": "npm run hints-doc && git diff --exit-code",
"gen-test-supergraph": "ts-node ./query-planner-js/src/__tests__/genTestSupergraph.ts",
"changeset-version": "changeset version && npm i",
"publish": "changeset publish",
"build-and-publish": "npm run compile && changeset publish",
"spell:check": "cspell lint --no-progress --config .cspell/cspell.yml || (echo 'Add any real words to ./cspell/cspell-dict.txt.'; exit 1)",
"use-repo-git-hooks": "git config core.hooksPath .git-hooks"
},
Expand Down

0 comments on commit c96e24c

Please sign in to comment.