Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to case insensitive header lookup #2339

Closed
wants to merge 3 commits into from

Conversation

vtipparam
Copy link

Setting the header Apollo-Query-Plan-Experimental has no effect. Setting the request header Apollo-Query-Plan-Experimental is expected to populate the query plan in the response but it does not. We are performing case sensitive lookup on the headers. See #2337 for details.

Adding expressMiddleware handler particularly exposes the issue. Will add a separate PR to address the expressMiddleware issue.

@apollo-cla
Copy link

@vtipparam: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Jan 18, 2023

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 22c9a36

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: 22c9a36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/gateway Patch
@apollo/federation-internals Patch
@apollo/composition Patch
@apollo/query-planner Patch
@apollo/query-graphs Patch
@apollo/subgraph Patch
apollo-federation-integration-testsuite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trevor-scheer
Copy link
Member

This shouldn't be necessary, the headers object in question here is:
https://github.com/apollographql/apollo-server/blob/c835637be07929e3bebe8f3b262588c6d918e694/packages/server/src/utils/makeGatewayGraphQLRequestContext.ts#L163-L164 (which uses the case-insensitive HeaderMap internally).

This should no longer be an issue via apollographql/apollo-server#7313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants