fix: Handle defaulted variables correctly during post-processing #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 110b971 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dariuszkuc
approved these changes
Mar 8, 2023
pcmanus
approved these changes
Mar 8, 2023
This was referenced Mar 8, 2023
trevor-scheer
added a commit
that referenced
this pull request
May 15, 2023
Post-processing didn't previously account for defaulted variable values in an operation at all. This surfaces as a problem when using conditional directives (@skip/@include) that use variables with defaulted values (and no corresponding variable provided). We should collect defaulted variable values from the operation and pass them along with the variables we provide to computeResponse so these are accounted for.
trevor-scheer
added a commit
that referenced
this pull request
May 15, 2023
Post-processing didn't previously account for defaulted variable values in an operation at all. This surfaces as a problem when using conditional directives (@skip/@include) that use variables with defaulted values (and no corresponding variable provided). We should collect defaulted variable values from the operation and pass them along with the variables we provide to computeResponse so these are accounted for.
trevor-scheer
added a commit
that referenced
this pull request
May 15, 2023
Post-processing didn't previously account for defaulted variable values in an operation at all. This surfaces as a problem when using conditional directives (@skip/@include) that use variables with defaulted values (and no corresponding variable provided). We should collect defaulted variable values from the operation and pass them along with the variables we provide to computeResponse so these are accounted for.
pcmanus
pushed a commit
that referenced
this pull request
May 16, 2023
Post-processing didn't previously account for defaulted variable values in an operation at all. This surfaces as a problem when using conditional directives (@skip/@include) that use variables with defaulted values (and no corresponding variable provided). We should collect defaulted variable values from the operation and pass them along with the variables we provide to computeResponse so these are accounted for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300
(more like #300 (comment))
Post-processing doesn't currently account for defaulted variable values in an operation at all. This surfaces as a problem when using conditional directives (
@skip/@include) that use variables with defaulted values (and no corresponding variable provided).We should collect defaulted variable values from the operation and pass them along with the
variableswe provide tocomputeResponseso these are accounted for.