Use graphql-js builtin function separateOperations
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loader's size/complexity was greatly reduced by GraphQL's builtin function. I also refactored the code structure/syntax to make it easier to reason about.
Mostly this just involved updating the order things were added to definitions. I had to mess around a bit with the `require` mocking to facilitate new code. I also unmocked require after each use, which was not being done.
detrohutt
commented
May 1, 2018
| assert.equal(Q1[0].name.value, 'Q1'); | ||
| assert.equal(Q1[1].name.value, 'F33'); | ||
| assert.equal(Q1[2].name.value, 'F22'); | ||
| assert.equal(Q1[3].name.value, 'F11'); |
There was a problem hiding this comment.
@jnwng This pattern is brittle (hence me needing to change the tests). The order shouldn't matter IMO. I stuck with the same pattern for now, but if you'd like I can add a commit to change it. I'd map the names to an array and then do an assert.include for each value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the changes discussed in #173.