Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typename insertion functionality to graphql-tag #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add typename insertion functionality to graphql-tag #265

wants to merge 1 commit into from

Conversation

dmhalejr
Copy link

@dmhalejr dmhalejr commented Jul 8, 2019

Aims to close #71

Leveraging the muscle of addTypenameToDocument from the apollo-utilities package to add ability to add __typenames when enabled.

Parameter defined was set as enableTypenameInsertion and disableTypenameInsertion appropriately

The one oddity from my quick feature creation was that the test/graphql-v0.11.js which I didn't touch changed ever so slightly where undefined and null became null and []

I'll change it back but my npm test yielded the same testing compatibility fails/passes as my fresh master fork.

Thanks for all you do! Let me know what else I can do to meet guidelines.

@apollo-cla
Copy link

@dmhalejr: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support addTypename as an option.
2 participants