Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exports field to package.json #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

P4sca1
Copy link

@P4sca1 P4sca1 commented Oct 27, 2021

https://nodejs.org/api/packages.html#conditional-exports

This should help with import errors in environments where module is not supported, but exports.import is.

@apollo-cla
Copy link

@P4sca1: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@P4sca1 P4sca1 changed the title Add exports field to package.json (#1) Add exports field to package.json Oct 27, 2021
@oooplz oooplz mentioned this pull request Dec 14, 2021
@hwillson hwillson closed this Jul 23, 2022
@hwillson hwillson reopened this Jul 23, 2022
@P4sca1
Copy link
Author

P4sca1 commented Jul 25, 2022

I signed the CLA a few months ago. Is there anything else I need to do?

@jpvajda
Copy link

jpvajda commented Aug 2, 2022

@P4sca1 No, that's all you need to do to contribute! Thanks for making this PR, the team will review this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants