Allow exporting ESM #808
Open
Allow exporting ESM #808
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkg20001: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Hey @mkg20001 👋 Thanks so much for the PR! For now I can't guarantee a timeline on when we will review/merge this PR as we are still figuring out our ESM strategy right now. Thanks for the thought put into this! |
|
Fyi ESM is now stable and esm loaders are "Release Candidate" as of node 20, so relying on this in production is no longer such a trouble as it used to be. https://nodejs.org/dist/latest-v20.x/docs/api/esm.html#modules-ecmascript-modules https://nodejs.org/dist/latest-v20.x/docs/api/module.html#customization-hooks |
This adds an option esm which if set to true changes the exports
to use ESM format
export default doc;
export const MyQuery = doc;
etc.
This allows usage with [node-esm-loader](npm.im/node-esm-loader)
```js
export default {
loaders: [
{
test: /\.(graphql|gql)$/,
use: [
{
loader: "graphql-tag/loader.js",
options: {
esm: true
}
}
]
},
],
};
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option esm which if set to true changes the exports to use ESM format
export default doc;
export const MyQuery = oneQuery(...);
etc.
This allows usage with node-esm-loader