Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass named options to graphql function #79

Merged
merged 1 commit into from Nov 22, 2021

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Nov 22, 2021

Similar to changes made by @brainkim in apollographql/apollo-client#8997, this commit fixes the React Apollo template application when built with graphql@16, since support for passing positional arguments was removed in graphql/graphql-js#2904. The named options style also works with graphql@15.

Similar to changes made by @brainkim in
apollographql/apollo-client#8997, this commit
fixes the React Apollo template application when built with graphql@16,
since support for passing positional arguments was removed in
graphql/graphql-js#2904.
@benjamn benjamn self-assigned this Nov 22, 2021
@benjamn benjamn added blocking Prevents production or dev due to perf, bug, build error, etc.. bug dependencies Pull requests that update a dependency file labels Nov 22, 2021
Copy link
Contributor

@brainkim brainkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankee!

@benjamn benjamn merged commit 35dad03 into main Nov 22, 2021
@benjamn benjamn deleted the pass-named-options-to-graphql-function branch November 22, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Prevents production or dev due to perf, bug, build error, etc.. bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants