Remove void from MutationFunction Promise return type (#3458)

* Remove `void` from `MutationFunction` Promise return type The resolved value of the returned `Promise` from a `MutationFunction` cannot be `void`. Fixes #3432. * Changelog update
apollographql · Sep 5, 2019 · a3dd7e6 · a3dd7e6
1 parent 331a68c
commit a3dd7e6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Changelog.md b/Changelog.md
@@ -20,6 +20,8 @@
   [@hwillson](https://github.com/hwillson) in [#3453](https://github.com/apollographql/react-apollo/pull/3453)
 - SSR enhancements to support `network-only` and `cache-and-network` fetch policies, along with changes to ensure disabled SSR queries are not fired. <br/>
   [@mikebm](https://github.com/mikebm) in [#3435](https://github.com/apollographql/react-apollo/pull/3435)
+- Remove `void` from the `MutationFunction`'s returned Promise types. <br/>
+  [@hwillson](https://github.com/hwillson) in [#3458](https://github.com/apollographql/react-apollo/pull/3458)
 - Documentation fixes. <br/>
   [@SeanRoberts](https://github.com/SeanRoberts) in [#3380](https://github.com/apollographql/react-apollo/pull/3380)
 

diff --git a/packages/common/src/types/types.ts b/packages/common/src/types/types.ts
@@ -142,7 +142,7 @@ export declare type MutationFunction<
   TVariables = OperationVariables
 > = (
   options?: MutationFunctionOptions<TData, TVariables>
-) => Promise<void | MutationFetchResult<TData>>;
+) => Promise<MutationFetchResult<TData>>;
 
 /* Subscription types */