Make ChildProps.data non-optional

[choffmeister]

Please see issue #1083

[apollo-cla]

@choffmeister: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[apollo-cla]

	Warnings
⚠️	There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

[leoasis]

I think you also need to update OptionProps defined above https://github.com/apollographql/react-apollo/pull/1143/files#diff-41df78d86ed4de80aae9b0b9560feb2bL65

[choffmeister]

True thx. Still there are tests failing which is weired, since I did not change any actual code. Also the tests suite does also not run through locally on master branch...

[leoasis]

The build fail seems to be related to some typescript checks that now fail because of the changed types: https://travis-ci.org/apollographql/react-apollo/builds/279954551#L773

[choffmeister]

OK, these error is from making data optional also on OptionProps. Before there was no typing error but just some unit tests failed. Will have to look into it.

[choffmeister]

@leoasis I reverted the part for OptionProps so this is at least correct for now. I am also not really sure that OptionProps.data is indeed optional. At least how it is implemented now it is not.

EDIT: Yes OptionProps.data is optional, since either .data or .mutate is filled.

[leoasis]

Hmm I think data can be optional in both cases, since you won't get it either in ChildProps when you set up a mutation.

[leoasis]

I think this one is a bit hard to typecheck, since the decision on wether this HoC acts as a mutation or as a query, really depends on the graphql Document that is passed to it, and it's determined at runtime.

Anyway, at least the other type should be Partial since that won't come when data is loading.

[jbaxleyiii]

I had no idea this even existed! So cool!

[jbaxleyiii]

hmm these test failures seem to be everywhere? I wonder what it is. Anyhow, its not related to this PR so I'll merge this through!

[leoasis]

@jbaxleyiii but won't data be undefined if we just use graphql for a mutation? I guess that why it was optional in the first place.

Also, I think OptionProps here https://github.com/apollographql/react-apollo/pull/1143/files#diff-41df78d86ed4de80aae9b0b9560feb2bL65 should have the same Partial treatment to TResult