This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Bundles #1769
Merged
Bundles #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmmm, I've just try to update to |
|
just tested with 2.1.0-rc.3, working! |
|
If your project is built with Create React App and not ejected, https://github.com/facebook/create-react-app/releases/tag/v1.1.2 Otherwise you can apply a similar fix yourself in your project config. Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sheesh, bundling is a mess in the js world today. This PR gives what I think is the best chance for future success?
This doesn't ship a flat bundle anymore, but looks like that may not be the best way forward. Instead we should work to get all Apollo projects to replicate the above so full tree shaking is possible. It will need to start with the Apollo Client repo for base utils, then include Apollo Link repo before this mjs will be particularly useful. This is part of the overall goals outlined here apollographql/apollo-link#537EDIT: This didn't work. It breaks usage with CRA which is impacting graphql-js too facebook/create-react-app#4085
This PR reverts any mjs inclusion for now