This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Remove onError and onCompleted from memoized options #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2019
hwillson
approved these changes
Aug 30, 2019
|
@hwillson Thank you for the quick review! Should I update the bundlesize? |
|
No problem at all @dylanwulf - I just bumped it, so we should be all set here. Thanks again! |
This was referenced Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
onErrorandonCompletedfrom theuseDeepMemokeys. These two props are often specified as inline functions which are different on every render, and should not be used as memo keys.Fixes #3406
Fixes #3407
Fixes apollographql/apollo-client#5241
Checklist: