This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Fix problematic fetchMore notifyOnNetworkStatusChange renders
#3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when `notifyOnNetworkStatusChange` is true calls to `fetchMore` do not wait for `updateQuery` to finish, before triggering a re-render. This means that after a `fetchMore` call, components will flip to `loading: true`, then `loading: false`, then un-necessarily re-render once more as `loading: false` with the result from `updateQuery`. This commit adds a check to see if `fetchMore` has been called and then holds off on re-rendering the `loading: false` state, until `updateQuery` has fully finished. Fixes #3333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, when
notifyOnNetworkStatusChangeis true calls tofetchMoredo not wait forupdateQueryto finish, before triggering a re-render. This means that after afetchMorecall, components will flip toloading: true, thenloading: false, then un-necessarily re-render once more asloading: falsewith the result fromupdateQuery. This commit adds a check to see iffetchMorehas been called and then holds off on re-rendering theloading: falsestate, untilupdateQueryhas fully finished.Fixes #3333