Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Update types.ts #3439

Closed
wants to merge 1 commit into from
Closed

Update types.ts #3439

wants to merge 1 commit into from

Conversation

lifeiscontent
Copy link

@lifeiscontent lifeiscontent commented Sep 1, 2019

data is never undefined, and in typescript it should be Partial for better merging mechanics.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

data is never undefined, and in typescript it should be Partial<TData> for better merging mechanics.
@abenhamdine
Copy link
Contributor

abenhamdine commented Sep 1, 2019

data is never undefined, and in typescript it should be Partial for better merging mechanics.

data should have been undefined when no data is available, and it will probably be fixed in next version, see #3388

@lifeiscontent lifeiscontent deleted the patch-1 branch September 3, 2019 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants