This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Better support for multiple useLazyQuery execution function calls
#3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, calling a `useLazyQuery` exection function multiple times in a row, when using a fetch policy of `network-only`, lead to unexpected results. Only the first network request was submitted as Apollo Client was blocking subsequent requests, since the query, fetch policy and variables remained the same. This commmit adds additional cleanup to the `useLazyQuery` exection function, such that each call will start a new `ObservableQuery` instance. This means each query fired by the `useLazyQuery` execution function is treated as a fully new query. Fixes #3355.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, calling a
useLazyQueryexecution function multiple times in a row, when using a fetch policy ofnetwork-only, lead to unexpected results. Only the first network request was submitted as Apollo Client was blocking subsequent requests, since the query, fetch policy and variables remained the same. This commit adds additional cleanup to theuseLazyQueryexecution function, such that each call will start a newObservableQueryinstance. This means each query fired by theuseLazyQueryexecution function is treated as a fully new query.Fixes #3355.