Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Remove void from MutationFunction Promise return type #3458

Merged
merged 2 commits into from Sep 5, 2019
Merged

Remove void from MutationFunction Promise return type #3458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
722f9c3
Remove `void` from `MutationFunction` Promise return type
hwillson Sep 5, 2019
e8a1060
Changelog update
hwillson Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Changelog.md
View file
Open in desktop
Expand Up @@ -20,6 +20,8 @@
[@hwillson](https://github.com/hwillson) in [#3453](https://github.com/apollographql/react-apollo/pull/3453)
- SSR enhancements to support `network-only` and `cache-and-network` fetch policies, along with changes to ensure disabled SSR queries are not fired. <br/>
[@mikebm](https://github.com/mikebm) in [#3435](https://github.com/apollographql/react-apollo/pull/3435)
- Remove `void` from the `MutationFunction`'s returned Promise types. <br/>
[@hwillson](https://github.com/hwillson) in [#3458](https://github.com/apollographql/react-apollo/pull/3458)
- Documentation fixes. <br/>
[@SeanRoberts](https://github.com/SeanRoberts) in [#3380](https://github.com/apollographql/react-apollo/pull/3380)

Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/types/types.ts
View file
Open in desktop
Expand Up @@ -142,7 +142,7 @@ export declare type MutationFunction<
TVariables = OperationVariables
> = (
options?: MutationFunctionOptions<TData, TVariables>
) => Promise<void | MutationFetchResult<TData>>;
) => Promise<MutationFetchResult<TData>>;

/* Subscription types */

Expand Down