This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Prevent duplicate onCompleted calls during query execution
#3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tweaks the dependencies that are watched to decide if `afterExecute` should be called (which triggers `onCompleted`), in `useQuery`. This helps prevent extra and un-necessary repeated calls to `onCompleted`, during a single query request-response cycle.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the dependencies that are watched to decide if
afterExecuteshould be called (which triggersonCompleted), inuseQuery. This helps prevent extra and un-necessary repeated calls toonCompleted, during a single query request-response cycle.