This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Make stopPolling / startPolling a no-op after unmount
#3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polling is automatically stopped when a component is unmounted, so it isn't necessary to call `stopPolling` during component cleanup. If it is called though, we don't want to throw an exception, so these changes make it (and `startPolling`) a no-op if component cleanup has already happened. Fixes #3482
hwillson
force-pushed
the
issue-3482
branch
from
c777687
to
dd7b6fe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polling is automatically stopped when a component is unmounted, so it isn't necessary to call
stopPollingduring component cleanup. If it is called though, we don't want to throw an exception, so these changes make it (andstartPolling) a no-op if component cleanup has already happened.Fixes #3482