Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: argument type for onCompleted in query #3496

Closed
wants to merge 1 commit into from
Closed

fix: argument type for onCompleted in query #3496

wants to merge 1 commit into from

Conversation

G07cha
Copy link

@G07cha G07cha commented Sep 14, 2019

'data' also could be an empty object according to documentation and real-life usage I've observed

See https://www.apollographql.com/docs/react/essentials/queries/#usequery-api

@apollo-cla
Copy link

@G07cha: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

'data' also could be an empty object according to documentation and real-life usage I've observed

See https://www.apollographql.com/docs/react/essentials/queries/#usequery-api
@hwillson
Copy link
Member

Thanks for the PR @G07cha. As of React Apollo 3.1.0 (and #3388 in particular), data should no longer be an empty object. Are you still seeing this happen with 3.1.0? If so, would you mind opening a new issue with a small runnable reproduction? Thanks!

@hwillson hwillson closed this Sep 15, 2019
@G07cha G07cha deleted the fix/on-completed-types branch September 15, 2019 12:04
@G07cha
Copy link
Author

G07cha commented Sep 15, 2019

@hwillson indeed, I've missed that one. It works as expected in 3.1.0, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants