Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Remove react-dom peer dep from react-apollo/hooks #3783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maclockard
Copy link

@maclockard maclockard commented Jan 2, 2020

Fixes #3704

Looked through all the files for this package and I didn't see any usage of react-dom or usage of dom elements so its unnecessary as a peer dep and could cause confusion for folks using react without react-dom. I didn't check other packages, so its possible the peer dep is extraneous elsewhere as well.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

Fixes apollographql#3704 

Looked through all the files for this package and I didn't see any usage of `react-dom` so its unnecessary as a peer dep. I didn't check other packages, so its possible the peer dep is extraneous elsewhere as well.
@apollo-cla
Copy link

@maclockard: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Q] React native @apollo/react-hooks has unmet peer dependency react-dom
2 participants