This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 793
Re-export all React Apollo functionality from @apollo/client #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreighton
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We're no longer building/testing files in this repo.
We're no longer maintaining examples in this repo.
`react-apollo` is a catch all package the re-exports each of the child React Apollo packages. We recommended people move away from using it when React Apollo 3 was launched, as it imported all of the React Apollo child packages, even if they weren't all being used. Now that we're going to React Apollo 4 (which will be the last version since all React Apollo functionality is available from `@apollo/client` directly), we're removing the `react-apollo` package completely. The individual React Apollo packages (e.g. `@apollo/react-hoc`) can still be used, but we recommend accessing the same functionality from `@apollo/client` directly.
All React Apollo functionality is now re-exported from `@apollo/client` directly, so the common package is no longer needed.
The Apollo components source is no longer managed in this repo.
The Apollo HOC source is no longer managed in this repo.
The React Apollo SSR source is no longer managed in this repo.
We no longer need the common package.
We're no longer developing/building/testing React Apollo functionality in this repo, so the package.json can be greatly simplified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have migrated all remaining React Apollo functionality into Apollo Client (apollographql/apollo-client#6558). After Apollo Client 3 launches, our recommendation is to use the following entry points:
@apollo/client/react/components
@apollo/client/react/hoc
@apollo/client/react/ssr
@apollo/client/testing
@apollo/client
This PR removes all source from this repo, re-exporting React Apollo functionality from
@apollo/client
. We will publish a final major version of all React Apollo packages (excluding the umbrellareact-apollo
package which we asked people to move away from when React Apollo 3 launched), that will just re-export functionality from@apollo/client
. While it will be possible to keep using the@apollo/react-X
packages, switching over to the@apollo/client
equivalents is recommended.