Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Use React API forceUpdate() for forceRenderChildren(). #775

Merged
merged 3 commits into from
Jul 5, 2017

Conversation

baerrach
Copy link
Contributor

Patch for #773

Using setState({}) causes unnecessary re-renders as {} is always a new object.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion
  • If this was a change that affects GitHunt-React, update GitHunt-React and post a link to the PR in the discussion

Using setState({}) causes unnecessary re-renders as {} is always a new object.
Copy link
Contributor

@helfer helfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaxleyiii jbaxleyiii merged commit 590847b into apollographql:master Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants