Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

move from string ref to callback ref #908

Merged
merged 4 commits into from
Aug 1, 2017

Conversation

koenpunt
Copy link
Contributor

since string refs are legacy

https://facebook.github.io/react/docs/refs-and-the-dom.html#legacy-api-string-refs

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@mention-bot
Copy link

@koenpunt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jbaxleyiii to be a potential reviewer.

@jbaxleyiii
Copy link
Contributor

@koenpunt thank you for this! I'm happy to merge it once the CI comes back green 👍

@koenpunt
Copy link
Contributor Author

koenpunt commented Jul 31, 2017

Oh well, that was Github's annoying auto-whitespace-insert in the online editor.
Should be all good now, also cleaned up the commits.

@jbaxleyiii jbaxleyiii merged commit 742e9b2 into apollographql:master Aug 1, 2017
@koenpunt koenpunt deleted the patch-1 branch August 1, 2017 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants