Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsupported access to parsed schema document #4715

Merged
merged 3 commits into from Mar 26, 2024
Merged

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Feb 22, 2024

Adds PluginInit::unsupported_supergraph_schema to allow plugins to gain read only access to the parsed supergraph schema.

This eliminates the need for plugins to reparse the string version in plugin init.

This is unsupported because apollo_rs is not 1.0 and may change before 1.0.

We WILL be changing the way we provide access to the parsed schema.

Use at your own risk.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@router-perf
Copy link

router-perf bot commented Feb 22, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

This eliminates the need for plugins to reparse the string versio in plugin init.

This is unsupported because apollo_rs is not 1.0 and may change before 1.0.

We WILL be changing the way we provide access to the parsed schema.

Use at your own reisk.
Copy link

@BrynCooke, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@BrynCooke BrynCooke changed the title Add unsupported access to parsed schema document. Add unsupported access to parsed schema document Feb 22, 2024
@BrynCooke BrynCooke enabled auto-merge (squash) March 25, 2024 14:02
@BrynCooke BrynCooke merged commit 0342fe8 into dev Mar 26, 2024
13 of 14 checks passed
@BrynCooke BrynCooke deleted the unsupported-ast-access branch March 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants