-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QueryPlannerConfig to QueryPlan key #5094
base: dev
Are you sure you want to change the base?
Conversation
@fotoetienne: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sounds ok, the only thing missing right now is hashing the planner config along with the metadata and others at https://github.com/apollographql/router/pull/5094/files#diff-560bfe015eb92a1ce9b2b1e2282f58d41574eeb3cb1d94385b5c8b96544e8b1cR546
(This part generates the redis cache key)
Then probably some tests will need to be updated, in particular the redis integration test. Do you want me to get it to the finish line or do you want to attempt it?
If you have the bandwidth, that would be great. Thanks! |
We'll take a look! |
Addresses Issue #5093
This is an incomplete PR (doesn't build yet) that demonstrates a proposed solution to Issue #5093