Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required updates following proto update #5124

Conversation

bonnici
Copy link
Contributor

@bonnici bonnici commented May 9, 2024

Updates snapshots and code to conform to the new protobuf spec.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@router-perf
Copy link

router-perf bot commented May 9, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch from cc9eedc to 9775f20 Compare May 9, 2024 01:15
@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch 25 times, most recently from 90d7f8f to 3b6b549 Compare May 16, 2024 20:09
@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch 3 times, most recently from 219f246 to 977ace6 Compare May 17, 2024 19:09
@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch 13 times, most recently from 060f1fc to a71bda0 Compare May 24, 2024 19:09
@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch 2 times, most recently from 13fe899 to 4888e32 Compare May 27, 2024 14:10
@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch from 9775f20 to 94e3ab7 Compare May 28, 2024 05:17
@bonnici bonnici force-pushed the create-pull-request/apollo-proto-updates branch from 7131698 to 7b4c861 Compare May 28, 2024 05:26
@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch from 7b4c861 to 5cb1c23 Compare May 28, 2024 06:24
@bnjjj
Copy link
Contributor

bnjjj commented May 28, 2024

@bonnici it doesn't compile

@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch from 4888e32 to 7449311 Compare May 28, 2024 10:10
@bonnici
Copy link
Contributor Author

bonnici commented May 28, 2024

github actions keeps overwriting my changes - i guess it's part of the automation that is set up. Maybe I can't make a PR that targets the autogenerated PR.

@github-actions github-actions bot force-pushed the create-pull-request/apollo-proto-updates branch from 7449311 to 187582a Compare May 28, 2024 14:09
@bonnici
Copy link
Contributor Author

bonnici commented May 29, 2024

Closing because github automation keeps overwriting any changes I make.

@bonnici bonnici closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants