Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(logging): put the right default values and available configuration for format #5161

Merged
merged 3 commits into from
May 15, 2024

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented May 14, 2024

No description provided.

…on for format

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj self-assigned this May 14, 2024
@bnjjj bnjjj requested a review from a team as a code owner May 14, 2024 07:50
@bnjjj bnjjj requested review from BrynCooke and removed request for a team May 14, 2024 07:50

This comment was marked as off-topic.

@bnjjj bnjjj requested review from lleadbet and a team May 14, 2024 07:50
@router-perf
Copy link

router-perf bot commented May 14, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@lleadbet
Copy link
Contributor

Changes look good, but we do need to remove client.address as well from default spans as it's currently not supported.

bnjjj added 2 commits May 14, 2024 16:09
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears as if @bnjjj addressed @lleadbet's suggestion even though it wasn't mentioned. With that done, LGTM.

@bnjjj bnjjj merged commit 5aae7c3 into dev May 15, 2024
13 of 14 checks passed
@bnjjj bnjjj deleted the bnjjj/docs_logging branch May 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants