disable flip property in popover components #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phwebi
force-pushed
the
bugfix/uncontrolled-tooltip-memory-leak
branch
2 times, most recently
from
bc3d3fe
to
253c2c2
Compare
phwebi
force-pushed
the
bugfix/uncontrolled-tooltip-memory-leak
branch
from
253c2c2
to
477c6f8
Compare
phwebi
force-pushed
the
bugfix/uncontrolled-tooltip-memory-leak
branch
from
e8850bd
to
5444152
Compare
gthomas-appfolio
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading
mycase_appto gears 5, we had come escalations regarding our calendar page freezing for certain users. @rmacklin discovered that this is related to a current memory leak issue inreactstrap(reactstrap/reactstrap#1587, reactstrap/reactstrap#1482), where the popover/tooltip component attempts to flip between top/bottom, and in the case where there's no room at all, there's an infinite loop that causes the page to crash.This PR disables the
flipfeature that causes the memory leaks. We can re-enable the feature once the issue is addressed inreactstrap.