Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support maxTypingFrequency in settings api #904

Merged

Conversation

ppken
Copy link

@ppken ppken commented May 17, 2024

Currently, maxTypingFrequency is supported only in capability. So we can't update it during test execution.
So, I added maxTypingFrequency setting to settings api to be able to update it at an arbitrary timing in a test execution.

Copy link

linux-foundation-easycla bot commented May 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mykola-mokhnach
Copy link

Thanks @ppken
Could you please sign CLA?

@ppken
Copy link
Author

ppken commented May 17, 2024

@mykola-mokhnach

Could you please sign CLA?

Thank you for your confirmation! I signed CLA but the alerts from CLA don't disappear since the commit is not linked to my account.
Let me push the same change with force-push to solve it and then let me address your review comments.

@ppken ppken force-pushed the support-maxtypingfrequency-in-settingapi branch from aff1304 to 06c8f70 Compare May 17, 2024 10:55
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mykola-mokhnach
Copy link

@ppken please don't forget to also update https://github.com/appium/appium-xcuitest-driver/blob/master/docs/reference/settings.md after this PR is merged

@KazuCocoa KazuCocoa merged commit fa4776a into appium:master May 17, 2024
42 of 43 checks passed
github-actions bot pushed a commit that referenced this pull request May 17, 2024
## [8.6.0](v8.5.7...v8.6.0) (2024-05-17)

### Features

* support maxTypingFrequency in settings api ([#904](#904)) ([fa4776a](fa4776a))
Copy link

🎉 This PR is included in version 8.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants