Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatic command doc gen for plugins #18029

Merged
merged 5 commits into from
Jan 10, 2023
Merged

automatic command doc gen for plugins #18029

merged 5 commits into from
Jan 10, 2023

Commits on Jan 10, 2023

  1. chore(types): update definition of PluginCommand type 

    maybe some day we will even use this!
    @boneskull
    boneskull committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    242543e View commit details
    Browse the repository at this point in the history

  2. feat(typedoc-plugin-appium): add plugin support 

    Most of this "just works", but the additional parameters to a plugin command need special handling.  To do that, we have to understand what is a plugin and what is not.

Note that this is incompatible with the "mixin" pattern as found in `BaseDriver` and `FakeDriver`. In other words, a _Plugin_ should not use mixin classes.  I would not recommend mixin classes going forward due to its complexity and opacity.
    @boneskull
    boneskull committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2d9b5aa View commit details
    Browse the repository at this point in the history

  3. fix(execute-driver-plugin): use correct return type annotation

    @boneskull
    boneskull committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    12b9358 View commit details
    Browse the repository at this point in the history

  4. docs: enable auto command generation for plugins 

    Also enables type checks in `execute-driver-plugins` and exports types where we weren't before
    @boneskull
    boneskull committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6a8b791 View commit details
    Browse the repository at this point in the history

  5. fix(execute-driver-plugin): fix bad types in execute-child module

    @boneskull
    boneskull committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e4836d2 View commit details
    Browse the repository at this point in the history