Improve : Optimize Dockerfile for Better Build Efficiency #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch name and pull request heading are clear and descriptive. The branch name indicates that the pull request is related to a feature, specifically the optimization of the Dockerfile. The heading of the pull request provides a concise summary of the changes made in the pull request.
ruomingp
approved these changes
Oct 20, 2023
|
@ruomingp Hey, could you please help me with this check? How do I pass this check? |
It seems a bug in the Dockerfile? |
markblee
reviewed
Oct 22, 2023
| RUN echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] http://packages.cloud.google.com/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list && \ | ||
| # Install necessary packages in a single layer. | ||
| RUN apt-get update && \ | ||
| apt-get install -y apt-transport-https ca-certificates gnupg curl gcc g++ git jq screen ca-certificates && \ |
There was a problem hiding this comment.
Seems like some of these are repeated from above (L10-11)?
Dockerfile
Outdated
| @@ -54,24 +46,31 @@ RUN ./run_tests.sh "${PYTEST_FILES}" | |||
| # Bastion container spec. # | |||
| ################################################################################ | |||
|
|
|||
| # Bastion container for application deployment. | |||
There was a problem hiding this comment.
nit: These comments are already covered in the comment blocks for each build target, e.g. L46 or L59.
markblee
reviewed
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request optimizes the Dockerfile by reducing the number of image layers, combining instructions, and improving readability. It also adds labels for better documentation. The Dockerfile is now more efficient and follows best practices for building Docker images.