-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #145
base: main
Are you sure you want to change the base?
Update README.md #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bullet point layout is quite neat. I'm not sure if we need to repeat the different sections from the ToC though. @ruomingp WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this change is motivated by the formatting changes? If so, let's decouple the wording and formatting changes?
@@ -14,6 +14,7 @@ | |||
|
|||
## Introduction | |||
|
|||
Welcome to AXLearn, a powerful deep learning library built on top of JAX and XLA. AXLearn is designed to support the development of large-scale deep learning models and offers a unique approach to tackling the software engineering challenges that arise during model development and maintenance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The claim about "unique" is not entirely accurate. The object-oriented approach was adopted at least by lingvo and paxml.
@@ -14,6 +14,7 @@ | |||
|
|||
## Introduction | |||
|
|||
Welcome to AXLearn, a powerful deep learning library built on top of JAX and XLA. AXLearn is designed to support the development of large-scale deep learning models and offers a unique approach to tackling the software engineering challenges that arise during model development and maintenance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's just me, but I'm not entirely comfortable with subjective adjectives such as "powerful". I feel that it's better for users to judge than for us to claim. WDYT?
No description provided.