Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR to add GoodPut Measurement #370

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jiya-zhang
Copy link
Contributor

Adding demo code as a skeleton to integrate GoodPut measurement into AXLearn.

To do's:

  1. Consider localizing GoodPut measurement to within trainer.py
  2. Make the measurement configurable
  3. Automatically pick up run_name from job config
  4. In order to obtain the GoodPut throughout a training's life time, consider repeatedly calling GoodPut Calculator and write the results to a persistent data store
  5. Add tests in AXLearn
  6. Test E2E for multislice jobs and larger single slice jobs
  7. Test E2E for long-running jobs (8hr+)
  8. Test for jobs running on v5e, v5p (so far, we only tested v4-8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant