-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataflow changes #384
base: main
Are you sure you want to change the base?
Dataflow changes #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some initial comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few additional suggestions while testing this PR:
- On L175, let's change to
cfg.command = f"{cfg.command.strip()} {dataflow_flags}"
so that trailing newlines in the command do not causedataflow_flags
to be interpreted as a separate command. - L249, similar change to
cmd = f"{cfg.setup_command.strip()} && {cmd}"
. - You may want to rebase onto latest
main
(which fixes the bundler specs) for local testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, also update the PR description?
@markblee Do you mind trigger the CI tests again? The error should disappear now that dependency issue was fixed and merged. (I don't have permission to rerun CI tests) |
It failed again with the same issue. Did you rebase? |
I changed a few things in this PR: