Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(axlearn): Fix typos #420

Merged
merged 1 commit into from
May 29, 2024
Merged

chore(axlearn): Fix typos #420

merged 1 commit into from
May 29, 2024

Conversation

tony
Copy link
Contributor

@tony tony commented Apr 24, 2024

Changes

Typo fixes

Tool-assisted (via typos --format brief --write-changes **/*.py via typos-cli). The rest of the effort is fine-tooth combing that output.

Aside: If you attempt this in the future in any way, do so carefully. This generated many false positives due to the nature of the library (e.g. nd -> and, empted -> emptied).

_typos.toml config used
[default]
extend-ignore-identifiers-re = [
    # *sigh* this just isn't worth the cost of fixing
    ".*nd.*",
    ".*ND.*",
    ".*preempt.*",
    ".*empt.*",
    ".*helpfull.*",
    ".*dout.*",
    ".*whos.*",
    ".*your.*",
    ".*stakeboard.*",
    ".*sur.*",
]

[files]
extend-exclude = ["*.vocab"]

Copy link
Contributor

@markblee markblee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

axlearn/common/summary_writer.py Outdated Show resolved Hide resolved
@tony
Copy link
Contributor Author

tony commented Apr 25, 2024

@markblee Yes!

Rebased against latest against main at 8419778.

@tony tony force-pushed the fix-axlearn-typos branch 5 times, most recently from 646b080 to f2e8a6e Compare April 27, 2024 11:03
@tony
Copy link
Contributor Author

tony commented Apr 27, 2024

Changes:

  • Squashed (fixupd) chore(axlearn): Fix typos #420 (comment) into main commit.
  • Rebased against main at b48ecc0.
    • Handmade fixes and new catches of this commit
  • PR Description: Added _typos.toml to the description, so it can be looked up later

@tony tony requested a review from markblee April 27, 2024 11:06
@tony tony force-pushed the fix-axlearn-typos branch 2 times, most recently from 1c58f97 to 3c5e3e3 Compare April 30, 2024 20:28
@tony tony force-pushed the fix-axlearn-typos branch 2 times, most recently from 40acde2 to 5d3f5b5 Compare May 14, 2024 22:12
Copy link
Contributor

@markblee markblee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@markblee markblee enabled auto-merge May 15, 2024 00:41
auto-merge was automatically disabled May 15, 2024 02:26

Head branch was pushed to by a user without write access

@tony tony force-pushed the fix-axlearn-typos branch 2 times, most recently from ed87136 to b550cd5 Compare May 15, 2024 02:30
@tony
Copy link
Contributor Author

tony commented May 15, 2024

@markblee Rebased, fixed pylint error.

@markblee markblee self-requested a review May 15, 2024 02:33
@markblee markblee enabled auto-merge May 15, 2024 02:34
auto-merge was automatically disabled May 15, 2024 22:42

Head branch was pushed to by a user without write access

@tony
Copy link
Contributor Author

tony commented May 15, 2024

@markblee Rebased again.

It's failing on pre-commit in re: contextlib2-21.6.0-py2.py3-none-any.whl:

Downloading smmap-5.0.1-py3-none-any.whl (24 kB)
Downloading yarl-1.9.4-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (304 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 304.3/304.3 kB 28.3 MB/s eta 0:00:00

Downloading contextlib2-21.6.0-py2.py3-none-any.whl (13 kB)
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
    unknown package:
        Expected sha256 bd95cee8511584b67ddc0ba465c3f1edeb5708d833ee02af1206b4486f1d9096
             Got        47b9fd1f3a7e0f372c0bf5a8f1521ca39a84ae3b098e3f73a3f62bc6d0b8f0fe


Exited with code exit status 1

@tony tony force-pushed the fix-axlearn-typos branch 3 times, most recently from 91b760e to a23a1d5 Compare May 19, 2024 13:27
@tony
Copy link
Contributor Author

tony commented May 29, 2024

@markblee Up to give it another shot? Rebased again (last run)

@markblee markblee enabled auto-merge May 29, 2024 22:37
@markblee markblee added this pull request to the merge queue May 29, 2024
Merged via the queue into apple:main with commit 0dd9760 May 29, 2024
3 checks passed
@tony tony deleted the fix-axlearn-typos branch May 30, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants