Support scheme-agnostic projects #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bioball
force-pushed
the
projects-from-any-uri
branch
2 times, most recently
from
270c9b7
to
c0bbe50
Compare
bioball
commented
May 20, 2024
| this.package != null | ||
| ) | ||
| const local function isUriLocal(uri1: String, uri2: String): Boolean = | ||
| uri1.substring(0, uri1.indexOf(":")) == uri2.substring(0, uri2.indexOf(":")) |
There was a problem hiding this comment.
This isn't the perfect check. This should also check that the URIs have the same authority. This is hard to implement without a URI API within the stdlib though.
I think we can improve this if/when we move pkl.experimental.uri to the standard library.
There was a problem hiding this comment.
I'd leave this comment in the code so we don't forget it.
bioball
force-pushed
the
projects-from-any-uri
branch
from
c0bbe50
to
30b3a03
Compare
stackoverflow
approved these changes
May 22, 2024
| @@ -34,4 +34,9 @@ examples { | |||
| ["glob-read absolute package uri"] { | |||
| read*("package://localhost:0/birds@0.5.0#/catalog/*.pkl") | |||
| } | |||
|
|
|||
| // https://github.com/apple/pkl/issues/166 | |||
There was a problem hiding this comment.
Suggested change
| // https://github.com/apple/pkl/issues/166 | |
| // https://github.com/apple/pkl/issues/166 |
| this.package != null | ||
| ) | ||
| const local function isUriLocal(uri1: String, uri2: String): Boolean = | ||
| uri1.substring(0, uri1.indexOf(":")) == uri2.substring(0, uri2.indexOf(":")) |
There was a problem hiding this comment.
I'd leave this comment in the code so we don't forget it.
HT154
approved these changes
May 22, 2024
|
Thanks for picking this up! I've looked through the changes made for SPICE-0005 conformance and everything makes sense to me. This also closes #166, which I'm delighted to see! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes and closes #255