Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc-java to 1.25.0 #877

Closed
idelpivnitskiy opened this issue Nov 23, 2019 · 0 comments · Fixed by #881
Closed

Update grpc-java to 1.25.0 #877

idelpivnitskiy opened this issue Nov 23, 2019 · 0 comments · Fixed by #881
Labels
good first issue Good for newcomers

Comments

@idelpivnitskiy
Copy link
Member

Google made a behavioral change in grpc-java 1.25.0:

protobuf: StatusProto.fromStatusAndTrailers fall-back to status if trailers are not available (#6278). Previously it returned null.

For more information see:

Because of that, a few of our ProtocolCompatibilityTests fail:

  • grpcJavaToGrpcJavaError
  • grpcJavaToServiceTalkError
  • grpcJavaToServiceTalkErrorInResponseNoOffload
  • grpcJavaToServiceTalkErrorInScalarResponse
  • grpcJavaToServiceTalkErrorViaServerFilter
  • grpcJavaToServiceTalkErrorViaServiceFilter

We should upgrade the version and investigate the change. Most likely we just need to adjust ProtocolCompatibilityTests. But we should verify that servicetalk-grpc-netty has exactly the same behavior as grpc-java when it generates status. That may require writing a new test if we do not cover this use-case.
@idelpivnitskiy idelpivnitskiy added the good first issue Good for newcomers label Nov 23, 2019
volyx added a commit to volyx/servicetalk that referenced this issue Nov 26, 2019
@volyx
Update grpc-java to 1.25.0 apple#877
62cab87 
Motivation:

Update grpc-java to 1.25.0

Modifications:

added `assertFallbackStatus` method to check new behaviour of `io.grpc.protobuf.StatusProto.fromStatusAndTrailers`

Result:

Fixes apple#877
@volyx volyx mentioned this issue Nov 26, 2019
Merged
volyx added a commit to volyx/servicetalk that referenced this issue Nov 27, 2019
@volyx
Update grpc-java to 1.25.0 apple#877
f3161c2 
Motivation:

Update grpc-java to 1.25.0

Modifications:

added fallbackStatus to StatusSupplier

Result:

Fixes apple#877
NiteshKant pushed a commit that referenced this issue Dec 3, 2019
@volyx
Update grpc-java to 1.25.0 #877 (#881)
4b2b4d5 
Motivation:

Update grpc-java to 1.25.0

Modifications:

added `assertFallbackStatus` method to check new behaviour of `io.grpc.protobuf.StatusProto.fromStatusAndTrailers`

Result:

Fixes #877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update grpc-java to 1.25.0 #877 volyx/servicetalk
1 participant
@idelpivnitskiy