Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc-java to 1.25.0 #877 #881

Merged
merged 2 commits into from Dec 3, 2019
Merged

Update grpc-java to 1.25.0 #877 #881

merged 2 commits into from Dec 3, 2019

Conversation

volyx
Copy link
Contributor

@volyx volyx commented Nov 26, 2019

Motivation:

Update grpc-java to 1.25.0

Modifications:

added assertFallbackStatus method to check new behaviour of io.grpc.protobuf.StatusProto.fromStatusAndTrailers

Result:

Fixes #877

@volyx
Update grpc-java to 1.25.0 apple#877
62cab87 
Motivation:

Update grpc-java to 1.25.0

Modifications:

added `assertFallbackStatus` method to check new behaviour of `io.grpc.protobuf.StatusProto.fromStatusAndTrailers`

Result:

Fixes apple#877
@servicetalk-bot
Copy link
Contributor

Can one of the admins verify this patch?

3 similar comments
@servicetalk-bot
Copy link
Contributor

Can one of the admins verify this patch?

@servicetalk-bot
Copy link
Contributor

Can one of the admins verify this patch?

@servicetalk-bot
Copy link
Contributor

Can one of the admins verify this patch?

@volyx
Copy link
Contributor Author

volyx commented Nov 26, 2019

It looks like update requires not only tests but also error handling logic in servicetalk-grpc-api module

Tests are passed now, but there is the difference between grpc-java services and servicetalk-grpc services.

Servicetalk's service returns null status here [1], but grpc's service returns fallback status [2].
I will continue investigating

[1] https://github.com/volyx/servicetalk/blob/update-grpc-java/servicetalk-grpc-netty/src/test/java/io/servicetalk/grpc/netty/ProtocolCompatibilityTest.java#L549
[2] https://github.com/volyx/servicetalk/blob/62cab8777be6925a6643d94ac51cddccf1514fa3/servicetalk-grpc-netty/src/test/java/io/servicetalk/grpc/netty/ProtocolCompatibilityTest.java#L563

@NiteshKant
Copy link
Collaborator

@servicetalk-bot test this please

@volyx
Update grpc-java to 1.25.0 apple#877
f3161c2 
Motivation:

Update grpc-java to 1.25.0

Modifications:

added fallbackStatus to StatusSupplier

Result:

Fixes apple#877
@volyx volyx marked this pull request as ready for review November 27, 2019 21:10
@idelpivnitskiy
Copy link
Member

@servicetalk-bot test this please

NiteshKant
NiteshKant approved these changes Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@NiteshKant NiteshKant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @volyx

@NiteshKant NiteshKant merged commit 4b2b4d5 into apple:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiteshKant NiteshKant NiteshKant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update grpc-java to 1.25.0
4 participants
@volyx @servicetalk-bot @NiteshKant @idelpivnitskiy