Streamline the creation of GRPC Exceptions #2571
Open
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods. Motivation: In reference to issue apple#2502, there should be a more convenient way to initialize GRPC Exceptions analogous to other GRPC implementations. Modifications: - Removed the deprecation from GrpcStatus.asException as it is required for this implementation of desired functionality. - Added additional constructor for GrpcStatus to support initialization from codeValue and description. - Added convenience method GrpcStatusCode.withDescription to support desired functionality. - Added GrpcStatusTest.testGrpcStatusExceptionFromGrpcStatusCode for test-driven development and better test coverage. Result: GRPC Exceptions can now be initialized and thrown more conveniently. What is the result of this change?
Motivation: Cleaner code and commit Modifications: - Removed an unnecessary empty line from GrpcStatus as well as an unused import from GrpcStatusTest Result: Cleaned up for pull request
cmwigard
changed the title
82baras
reviewed
Jul 22, 2023
| */ | ||
| @Deprecated | ||
| public GrpcStatusException asException() { // FIXME: 0.43 - remove deprecated method | ||
| public GrpcStatusException asException() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In reference to issue #2502, there should be a more convenient way to initialize GRPC Exceptions analogous to other GRPC implementations.
Modifications:
Result:
GRPC Exceptions can now be initialized and thrown more conveniently.