loadbalancer-experimental: thread lbDescription into the LoadBalancerObserver #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Observer Motivation: We already have a standard resource identifier for use when logging load balancer concerns: lbDescrption. However, we don't use that for the LoadBalancerObserver type because we don't know it on construction. Modifications: - Change the LoadBalancerBuilder to take a factory of LoadBalancerObservers which will consume the lbDescription during load balancer construction. - Deprecate the older API for a release cycle. Result: Better logging.
bryce-anderson
commented
May 16, 2024
| /** | ||
| * Factory of {@link LoadBalancerObserver} instances. | ||
| */ | ||
| public interface LoadBalancerObserverFactory { |
There was a problem hiding this comment.
Its worth debating on whether we want to create a real type here or just use Fuction<String, LoadBalancerObserver>. I like the interface because it gives a place to document what the parameter will be, but we could arguably do that in the loadBalancerObserver(Fuction<String, LoadBalancerObserver>) method. Opinions welcome.
There was a problem hiding this comment.
Either way works for me, in this case it's likely gonna be a lambda anyways.
Consider adding @FunctionalInterface annotation
idelpivnitskiy
approved these changes
May 16, 2024
| /** | ||
| * Factory of {@link LoadBalancerObserver} instances. | ||
| */ | ||
| public interface LoadBalancerObserverFactory { |
There was a problem hiding this comment.
Either way works for me, in this case it's likely gonna be a lambda anyways.
Consider adding @FunctionalInterface annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We already have a standard resource identifier for use when logging load balancer concerns: lbDescrption. However, we don't use that for the LoadBalancerObserver type because we don't know it on construction.
Modifications:
Result:
Better logging.