Filter backticks in TestItem IDs #1211
Open
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test functions with backticks in their identifier should have them filtered out. This is a stopgap until apple/swift-syntax#2576 is ready.
|
@swift-ci Please test |
ahoppen
reviewed
May 1, 2024
Comment on lines
+72
to
+73
| self.id = id.filter { $0 != "`" } | ||
| self.label = id == label ? self.id : label |
There was a problem hiding this comment.
I would prefer to only do the filtering on the function name. Once we start including the file’s name in the ID (#1152), we shouldn’t remove the backtick from eg. the filename.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test functions with backticks in their identifier should have them filtered out.
This is a stopgap until apple/swift-syntax#2576 is ready.