Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code actions for adding library/executable/macro targets to a package manifest #1240

Merged
merged 2 commits into from
May 17, 2024

Conversation

DougGregor
Copy link
Member

Add code actions for introducing new library, executable, or macro targets to a package manifest. I'm a little unhappy with these because we have to pick a name for the target (we choose "NewTarget") and it's a little annoying to change it after the fact. On the other hand, this at least puts the right structural pieces in place.

@DougGregor
Copy link
Member Author

Only the second commit is new...

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci please test Windows

@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci clean test Windows

1 similar comment
@DougGregor
Copy link
Member Author

apple/swift-package-manager#7481

@swift-ci clean test Windows

@DougGregor
Copy link
Member Author

apple/swift#73507

@swift-ci please test

}

/// Produce code actions to add new targets of various kinds.
static func addTargetActions(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be private, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure

@DougGregor DougGregor merged commit c2af2f5 into apple:main May 17, 2024
3 checks passed
@DougGregor DougGregor deleted the code-action-add-target branch May 17, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants