-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code actions for adding library/executable/macro targets to a package manifest #1240
Conversation
Only the second commit is new... |
apple/swift-package-manager#7481 @swift-ci please test |
apple/swift-package-manager#7481 @swift-ci please test Windows |
apple/swift-package-manager#7481 @swift-ci clean test Windows |
1 similar comment
apple/swift-package-manager#7481 @swift-ci clean test Windows |
@swift-ci please test |
} | ||
|
||
/// Produce code actions to add new targets of various kinds. | ||
static func addTargetActions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be private
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sure
Add code actions for introducing new library, executable, or macro targets to a package manifest. I'm a little unhappy with these because we have to pick a name for the target (we choose "NewTarget") and it's a little annoying to change it after the fact. On the other hand, this at least puts the right structural pieces in place.