Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify @Argument and @Option initialization paths #477

Merged
merged 2 commits into from Sep 10, 2022
Merged

Unify @Argument and @Option initialization paths #477

merged 2 commits into from Sep 10, 2022

Commits on Sep 9, 2022

  1. Unify @argument and @option initialization paths 

    - Fixes #466.
- Adds initializers to ArgumentDefinition generic over a Container type.
  The Container type must conform to a new internal protocol
  ArgumentDefinitionContainer which describes functionality like default
  set of help options for the argument defined by the property wrapper,
  etc.
- Adds overloads for Optional @arguments and @options with default
  values which emit deprecation warning to guide users towards using the
  non-Optional versions.
    @rauhul
    rauhul committed Sep 9, 2022
    Copy the full SHA
    16141d8 View commit details
    Browse the repository at this point in the history

  2. review feedback

    @rauhul
    rauhul committed Sep 9, 2022
    Copy the full SHA
    bebda5b View commit details
    Browse the repository at this point in the history