Add upcoming feature flag to SE-0414 to match inclusion in compiler #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Annotate that flag is always enabled in Swift 6 language mode
Ah, this is incorrect. I think this section of the proposal was not updated after it was revised. The decision notes from both rounds of review include changes the impact source compatibility:
Yes, the entire analysis is gated behind the upcoming feature flag |
rjmccall
added
LSG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upcoming feature flag is included for SE-0414 in the definition of upcoming features in the compiler.
However, the proposal states that there are no source compatibility issues introduced by this feature: https://github.com/apple/swift-evolution/blob/main/proposals/0414-region-based-isolation.md#source-compatibility
This PR adds the upcoming feature flag to the proposal header. The header also includes the new 'Enabled in Swift 6 language mode' annotation to indicating when the feature will be enabled.
However, typically a proposal describes what breaking changes are gated by the upcoming feature flag.
Is there any additional information as to what this upcoming feature flag enables, what changes will take effect if it is enabled prior to Swift 6 language mode?
Will the upcoming feature flag turn on the entire region based isolation feature in Swift 5 language mode?
I would be happy to add any additional information provided to this PR so the effect of the flag is documented in the proposal.
// cc-ing authors and review manager to ask for additional information and ensure this PR is correct
@gottesmm @JTurcotti @hborla