SE-0306 Actors: Make Types consistent in re-entrancy sample code #2447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been reading up on Actors, and think that there are some Type name errors in the sample code. Forgive me if I have misunderstood and got this wrong....
In the re-entrancy section there is some sample code showing how a value can change across
await
s.The types don't match - I suspect that at some point
Person
was changed toDecisionMaker
but not all occurrences of the type name were changed in the sample code.The Actor type should either be a
Person
or aDecisionMaker
Similarly theopinion
property's type should either beJudgment
or 'Decision'