-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a string-specific search algorithm #715
Open
natecook1000
wants to merge
14
commits into
main
Choose a base branch
from
string-search-algorithm
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Boyer-Moore substring search algorithm, and updates the `firstRange(of:)` and `ranges(of:)` methods to use that when both pieces of the search are strings/substrings. Still need to look at availability and switch the "replacing" methods to use this new search algorithm.
natecook1000
force-pushed
the
string-search-algorithm
branch
from
February 16, 2024 00:40
85245ff
to
ded493c
Compare
For large strings, a recursive search can run out of stack space. This eliminates the issue by looping within the `nextRange` function.
@swift-ci Please test |
@swift-ci Please test |
@swift-ci Please test |
Benchmark metrics of the improvements:
|
Updated the algorithm to skip calculating the bad-character offset table when the pattern is very short, since the benefit of skipping is reduced. Updated benchmarks:
|
@swift-ci Please test |
1 similar comment
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Boyer-Moore substring search algorithm, and updates the
firstRange(of:)
,ranges(of:)
,split(...)
, andreplacing
methods to use that when both pieces of the search are strings/substrings.