Make DiagnosticDecorator semi-public
#2557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What’s your motivation for making the type public? Do you expect clients to provide their own diagnostic formatter? |
|
Yes, indeed. The original intension was to allow clients to customize diagnostic formatters. |
|
Sorry for the delay: Do you have a concrete example of a client that might want to customize the diagnostic formatter? I would prefer to not increase the API surface area unnecessarily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactored implementation of
DiagnosticFormatter, as seen in this pull request, is now closely integrated withDiagnosticDecorator. In order to expose the new initializers and methods ofDiagnosticFormatteras public, it's necessary to also makeDiagnosticDecoratorpublic.Given that
decorateHighlightis still experimental, I've renamed it to start with an underscore (_) and added a warning to it's documentation to emphasize that this API is not yet intended for production use.