Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Macro plugin related changes #2643

Merged
merged 3 commits into from
May 23, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 6, 2024

Cherry-pick recent macro plugin related changes to release/6.0

Info:

  • Explanation: Bundle of recent macro plugin related changes. By this, the compiler uses the same JSON encoder/decoder as the plugins including swift-plugin-server. Also, move most of the swift-plugin-server code to swift-syntax repository. This improves re-usability of the code, so other future components can use it.
  • Risk: Mid, Changing JSON coder has some risk, but the new coder has more test coverage. Also, this changes the type discovery mechanism of swift-plugin-server form dlsym type metadata accessors to _typeByName runtime function, but the function exist for long time and well reliable.
  • Scope: Macro plugins
  • Issue: N/A
  • Reviewer: Alex Hoppen (@ahoppen) Hamish Knight (@hamishknight)

Separate message listening logic from 'CompilerPluginMessgeHandler' to
'CompilerPluginMessageListener', so 'CompilerPluginMessageHandler' can be
used independently without 'MessageConnection'

(cherry picked from commit b27503b)
LibraryPluginProvider is a 'PluginProvider' type that can load shared
library plugins at runtime.

(cherry picked from commit 1c9eb89)
@rintaro
Copy link
Member Author

rintaro commented May 6, 2024

apple/swift#73458
@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented May 21, 2024

apple/swift#73458
@swift-ci Please test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented May 22, 2024

apple/swift#73458
@swift-ci Please test

@rintaro rintaro merged commit 5e288d6 into apple:release/6.0 May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants